[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFC] Patch to disable GTK in installer images



On Sat, 2009-12-05 at 20:08 +0100, Frans Pop wrote: 
> On Saturday 05 December 2009, Ian Campbell wrote:
> > On Sat, 2009-12-05 at 09:33 +0100, Frans Pop wrote:
> > > > +++ b/installer/build/config/i386/cdrom-xen.cfg
> > > > @@ -1,6 +1,6 @@
> > > >  KERNELVERSION = $(BASEVERSION)-686-bigmem
> > > > -TYPE=cdrom/gtk
> > > > -include config/i386/cdrom/gtk.cfg
> > > > +TYPE=cdrom/isolinux
> > > > +include config/i386/cdrom.cfg
> > >
> > > Last line should probably be:
> > > +include config/i386/cdrom/isolinux.cfg
> >
> > I'm not sure what the practical difference is in d-i terms but Xen
> > doesn't need any isolinux stuff and the extra packages in
> > pkg-lists/cdrom/isolinux/i386.cfg don't seem relevant to Xen.
> 
> This isn't really about including any isolinux stuff, but simply about 
> referencing the closest newt-frontend equivalents of current gtk-frontend 
> references. That simply gives the smallest risk of breakage from disabling 
> the gtk targets. Maybe it's not strictly needed, but it is also least 
> likely to do harm.

Thanks for the explanation, sounds fine.

Cheers,
Ian.



-- 
Ian Campbell

There's nothing like the face of a kid eating a Hershey bar.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: