Re: [d-i on kfreebsd] quick status report
On Sun, Aug 09, 2009 at 09:46:07AM +0200, Felix Zielcke wrote:
> Am Samstag, den 08.08.2009, 21:06 +0200 schrieb Robert Millan:
> > On Fri, Aug 07, 2009 at 08:53:06AM +0200, Felix Zielcke wrote:
> > > --- grub-installer (revision 60026)
> > > +++ grub-installer (working copy)
> > > @@ -115,7 +115,7 @@ convert () {
> > > tmp_disk=$(echo "$1" | sed 's%\([sh]d[0-9]*\).*%\1%')
> > > tmp_part=$(echo "$1" | sed "s%$tmp_disk%%")
> > > ;;
> > > - freebsd*)
> > > + freebsd*|gnu/kfreebsd*)
> > > tmp_disk=$(echo "$1" | sed 's%r\{0,1\}\([saw]d[0-9]*\).*$%r\1%' | \
> > > sed 's%r\{0,1\}\(da[0-9]*\).*$%r\1%')
> > > tmp_part=$(echo "$1" | \
> > > @@ -166,7 +166,7 @@ convert () {
> > > fi
> > > echo "$tmp_drive"
> > > ;;
> > > - freebsd*)
> > > + freebsd*|gnu/kfreebsd*)
> > > if echo $tmp_part | grep "^s" >/dev/null; then
> > > tmp_pc_slice=$(echo $tmp_part | \
> > > sed "s%s\([0-9]*\)[a-h]*$%\1%")
> >
> > I think the convert() function is only used for GRUB Legacy.
>
> Ah I didn't looked it up before.
> convert() gets only used for the os-prober entrys, but there for both
> grub-legacy and grub2.
> grub-probe is still not used.
The GRUB 2 ones don't work, because this routine uses Legacy disk/partition
numbering.
A while ago I sent a patch to fix this problem by switching to grub-probe:
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=13;filename=grub-installer.diff;att=1;bug=473401
At this point, keeping the convert() function doesn't provide any benefit,
even for GRUB Legacy. If grub-probe couldn't be used for this conversion,
install would fail anyway.
But it does work. It shipped with Lenny this way.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
Reply to: