[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#498143: Please detect non-ISO block devices masquerading as Debian CDs



Chris Lamb wrote:

> However, on [Debian Live] USB/HDD images, cdrom-detect naturally fails
> to locate the partition on which the d-i components reside, as it is
> neither an ISO9660 image nor contained on a block device returned by
> `list-devices cd` or `list-devices maybe-usb-floppy`.

Okay, whilst I haven't been following this up, Ubuntu have merged an
almost identical fix:

 https://bugs.launchpad.net/ubuntu/+source/cdrom-detect/+bug/234185

Synopsis of the changes:

 - Adding support for `list-devices usb-partition` to di-utils.
 - Searching these devices in cdrom-detect if "cdrom-detect/try-usb" is
   true.
 - Confirming /cdrom/.disk/info exists to prevent weird stuff happening.
 - Save the fstype of what we mounted /cdrom as in "cdrom-detect/cd_fs"
   and when remounting /cdrom in apt-setup, look at it so we don't try
   and remount a vfat partition as iso9660, etc.

Colin can probably point out stuff I've missed. Anyway, it would be nice
if we could merge these changes so Debian Live can get USB installs
working without ugly hacks.

Where it is deficient is that it does not support 'ext' nor installation
from non-USB media but I feel we can address these at a later date;
whilst they would be nice to support they are relatively rare from our
point of view.

Anyway, if there is no objection to the approach I'll prepare a patch
and post it back here. I am at DebConf if you want to flame/whatever in
person.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org
       `-

Attachment: signature.asc
Description: PGP signature


Reply to: