[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#538265: Add disable netcfg preseed option



Hello Anthony,

I agree with the idea but I'd like you do to few changes on the
proposed patch for us to push it. Please look bellow for my comments
on the patch:

On Fri, Jul 24, 2009 at 11:01 AM, Anthony L. Awtrey<tony@awtrey.com> wrote:
[...]
> diff -urN netcfg-1.46.orig/debian/netcfg-common.templates
> netcfg-1.46/debian/netcfg-common.templates
> --- netcfg-1.46.orig/debian/netcfg-common.templates     2008-08-09
> 19:34:13.000000000 +0000
> +++ netcfg-1.46/debian/netcfg-common.templates  2009-07-24
> 15:27:30.000000000 +0000
> @@ -1,3 +1,12 @@
> +Template: netcfg/enable_netcfg

Please use netcfg/enable

> +Type: boolean
> +Default: true
> +# :sl1:
> +_Description: Enable network configuration during Install?

Please change it to be a preseed only template. It avoid useless work
for translators and also keep the templates smaller since noone is
going to be asked about it.

Anyway, thanks in advance by looking at it :-)

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br



Reply to: