[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Revert r56948? (console-setup: fix keymap reduction)

On Sat, Jan 31, 2009 at 07:44:59PM +0200, Anton Zinoviev wrote:
> I would like to revert r56948 unless there is something I don't see. As 
> far as I can remember this change increases the size of the precompiled 
> keymaps by many times.

I tested this.  With the new xkb data files the change in size is 
insignificant - for the standard pc keyboards before r56948 it was 94K 
and after r56948 it is 96K.

> I think r56948 makes only the following improvement:

Actualy it seems at present r56948 makes no improvement.  In order to 
make r56948 do what I think it is supposed to do one has to change also 
another line in kbdcompiler (I haven't tested this):

--- kbdcompiler	2009-01-31 21:34:04.360510128 +0200
+++ kbdcompiler2	2009-01-31 22:06:26.328010042 +0200
@@ -170,7 +170,7 @@
     my $mink1 = '';
     my $mink2 = '';
     my $minsub = 10000000;
-    for $k1 (keys %kmaps, '') {
+    for $k1 ('', keys %kmaps) {
 	for $k2 (keys %kmaps) {
 	    next if ($k1 eq $k2);
 	    if ($k1 eq '') {

Anton Zinoviev

Reply to: