Quoting Frans Pop (elendil@planet.nl): > On Saturday 23 August 2008, Samuel Thibault wrote: > > Author: sthibaul-guest > > Date: Sat Aug 23 00:22:05 2008 > > New Revision: 55173 > > > > Log: > > * Optionally add a beep to the x86 syslinux menu, controlled by > > BOOTMENU_BEEP. This is enabled by default only for release builds. > > With this patch (after fixing a syntax error) I'm hearing beeps *during* > D-I image builds. I don't really like that... > > > And looking at the patch ... > > + if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \ > + addbeep="s/^menu title.*/&/"; \ > + else \ > + addbeep=""; \ > + fi; \ > cat $(file) \ > | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \ > DEBIAN_VERSION "$(DEBIAN_VERSION)" \ > @@ -222,6 +239,7 @@ > INITRD_GTK /install/gtk/initrd.gz \ > VIDEO_MODE $(VIDEO_MODE) \ > VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \ > + | sed -e "$$addbeep" \ > > ... I also don't like that if BOOTMENU_BEEP != y we apparently execute > 'sed -e ""'. It may work, but it's not pretty. I guess that this patch is also what broke my daily builds, indeed..:-) (see report on IRC)
Attachment:
signature.asc
Description: Digital signature