[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#462396: Multiple disks support for partman-auto-lvm

On Thu, Jul 31, 2008 at 10:31:11PM +0200, Grégory Oestreicher wrote:
> Le mercredi 30 juillet 2008 01:48, Jérémy Bobbio a écrit :
> > > Some minor refactoring was needed when writing the code, so why not doing
> > > it while it's still hot ? However I can submit two separate patches if
> > > it's clearer.
> >
> > I'm already asking quite some work, but if you have the energy, it would
> > be lovely. 
> Here is the patch concerning the refactoring part. I moved the definition of 
> dev_to_partman outside of partman-auto-raid and replaced it by the 
> appropriate include, but couldn't see the function used anywhere. As I have 
> no time / resources to test this I chose to do it this way, but if someone 
> knows for sure the function is not needed I can remove the inclusion.

As far as I have been able to dig through the history, it has never
actually been used.  initial_auto_raid probably started as a copy of
initial_auto and the function was probably never removed.

This part of your patch is pending on my queue.

> I also added the definition of some function used in the second part of the 
> patch. The envelope creation is now a separate function as it is called 
> twice. I think the functional changes patch will be ready this week end 
> (2008-08-03) for review, after all required tests on my side.

NACK for get_disk_infos().  This name does not reflect at all what the
function does, as far as I understand it.

Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 

Attachment: signature.asc
Description: Digital signature

Reply to: