[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#492205: installation-reports: firmware load testing



dann frazier wrote:
> I couldn't get this image to work; it seems to load bnx2 on startup
> automatically and, after a 'modprobe -r bnx2', it doesn't seem to ever
> bring up the fw prompt.

The only change I've made that could affect the firmware prompt at all is this
one:

-                for line in $(cat $LOG.old); do
+                for line in $(sort $LOG.old | uniq); do

Unless my image is just broken in some way, and /tmp/missing-firmware
doesn't get populated, or check-missing-firmware fails to run.

> And this is because "$files" has a trailing space:

Ah, I see it now, it does in fact always add a trailing space.
And the fix I already checked in to make list_deb_firmware avoid listing empty
lines didn't actually fix that, because grep "" file matches all lines
in the file. Ok, fix checked in.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: