Bug#492205: installation-reports: firmware load testing

[dann frazier <dannf@debian.org>]

On Thu, Jul 24, 2008 at 04:16:48PM -0400, Joey Hess wrote:
> J?r?my Bobbio wrote:
> >  * Firmware packages should not be installed for firmware that were not
> >    explicitely required.
> > 
> >    This would need further investigation as the code, as far as I can
> >    see, should filter out the packages present on the media based on
> >    needed firmware files.
> 
> The filtering worked in my testing. Before I go off on a wild goose
> chase, are we sure that Dan didn't dump the debs into
> /var/cache/firmware/ in d-i? Because it would pefectly explain it trying
> to install all the debs from there.

Yeah, I'm sure :)

> Hmm, tested again, code still seems to work:
> 
> # files="foo bar"
> # echo "$files" | sed -e 's/ /\n/g' >/tmp/grepfor
> # cat /tmp/grepfor 
> foo
> bar
> # list_deb_firmware () {
>  # list_deb_firmware () {
> >         ar p "$1" data.tar.gz | tar zt \
> >                 | grep '^\./lib/firmware/' \
> >                 | sed -e 's!^\./lib/firmware/!!'
> > }
> # list_deb_firmware zd1211-firmware_2.16.0.0-0.1_all.deb 
> 
> zd1211/
> zd1211/zd1211_ub
> zd1211/zd1211_uph
> zd1211/zd1211_uphm
> zd1211/zd1211_uphr
> zd1211/zd1211_ur
> zd1211/zd1211b_ub
> zd1211/zd1211b_uph
> zd1211/zd1211b_uphm
> zd1211/zd1211b_uphr
> zd1211/zd1211b_ur
> # list_deb_firmware zd1211-firmware_2.16.0.0-0.1_all.deb  | grep -qf /tmp/grepfor
> # echo $?
> 1
> # 
> 
> It does, however, think that every deb contains a firmware file named "", so if
> it somehow thinks it needs such a file, it will try to use every deb to provide
> it:
> 
> /ff # files="foo bar "
> /ff # echo "$files" | sed -e 's/ /\n/g' >/tmp/grepfor
> /ff # list_deb_firmware zd1211-firmware_2.16.0.0-0.1_all.deb  | grep -qf
> /tmp/grepfor
> /ff # echo $?
> 0
> 
> I don't see how $files could get an extra leading/trailing space to
> tickle this problem, unless a module actually requests a firmware file
> with a space in its name. But I've checked in a fix for it anyway..

The bnx2 module requests 2 pieces of firmware - maybe that has
something to do with it?

-- 
dann frazier