On Tuesday 27 May 2008, Colin Watson wrote:
> Author: cjwatson
> Date: Tue May 27 09:17:38 2008
> New Revision: 53484
>
> Log:
> Move 'local' down a line in create_new_partition in order to work
> properly with bash, which initialises local variables without an
> accompanying assignment to empty rather than to any previous value.
>
> Modified:
> trunk/packages/partman/partman-partitioning/debian/changelog
> trunk/packages/partman/partman-partitioning/free_space/new/do_option
[...]
> create_new_partition () {
> - local num id size type fs path name mp mplist mpcurrent numparts device
> open_dialog NEW_PARTITION $type ext2 $freeid $place $size
> + local num id size type fs path name mp mplist mpcurrent numparts device
> id=''
> read_line num id size type fs path name
> close_dialog
I don't get this. Why is this move needed?
It looks wrong to me as now some vars are being defined as local after they
are first used.
Should the local line maybe be split into two lines instead?
Can you elaborate?
Cheers,
FJP
Attachment:
signature.asc
Description: This is a digitally signed message part.