On Fri, May 02, 2008 at 06:49:00PM +0800, Glenn Saberton wrote:
> Once the WPA cases are added, the enum spans many columns. Break it
> into one line per tag.
> […]
> - enum { BACKUP, GET_INTERFACE, GET_HOSTNAME_ONLY, GET_STATIC, WCONFIG, WCONFIG_ESSID, WCONFIG_WEP, QUIT} state = GET_INTERFACE;
> + enum { BACKUP,
> + GET_INTERFACE,
> + GET_HOSTNAME_ONLY,
> + GET_STATIC,
> + WCONFIG,
> + WCONFIG_ESSID,
> + WCONFIG_WEP,
> + QUIT }
> +
> + state = GET_INTERFACE;
"state" should be on the same line than the closing bracket. Otherwise,
it is unclear that the enum is actually a type definition for state.
Same comment on the other half of this patch.
Cheers,
--
Jérémy Bobbio
Attachment:
signature.asc
Description: Digital signature