[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFC] [PATCH] WPA PSK support for netcfg



Quoting Glenn (gsaberton@internode.on.net):

> +Template: netcfg/wireless_security_type
> +Type: select
> +__Choices: Wep/Open, WPA PSK
> +# :sl2:
> +_Description: Wireless Network Type for ${iface}:
> + Chose Wep/Open if the network is open or secured with wep.
> + Chose WPA if the network is a WPA PSK protected network.

s/Chose/Choose

And being as polite as expected, I'd go for "Please choose"..:-)


> +
>  Template: netcfg/wireless_wep
>  Type: string
>  # :sl1:
> @@ -80,6 +88,19 @@
>   the next screen carefully on how to enter your WEP key correctly, and try
>   again.
>  
> +Template: netcfg/invalid_pass
> +Type: error
> +# :sl2:
> +_Description: Invalid passphrase
> + The WPA PSK passphrase was either too long (more than 64 characters)
> + or too short (less than 8 characters)

Missing final dot (sorry this is probably my own fault)


> +
> +Template: netcfg/wireless_wpa
> +Type: string
> +# :sl1:
> +_Description: WPA passphrase for wireless device ${iface}:
> + Enter a WPA PSK passphrase.

I still think the long description ("Enter a WPA PSK passphrase")
doesn't add much information.

> +Template: netcfg/no_wpa_supplicant
> +Type: error
> +# :sl2:
> +_Description: Wpasupplicant not found
> + The wpa_supplicant binary was not found on the system.
> + Chose WEP/Open wireless network, otherwise chose wired network.

s/Chose/Choose.

After thinking I'd maybe go for:

"Please choose either a WEP/Open wireless network or a wired network."


> +
>  Template: netcfg/kill_switch_enabled
>  Type: note
>  # A "kill switch" is a physical switch found on some network cards that
> @@ -257,7 +285,7 @@
>  Type: text
>  # base-installer progress bar item
>  # :sl1:
> -_Description: Storing network settings...
> +_Description: Storing network settings ...

That extra space is still here..:-)



Sorry for not commenting the code. That part is much beyond my field
of competence.


Attachment: signature.asc
Description: Digital signature


Reply to: