Re: [PATCH] Support for "hardware burn-in" stage (updated)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Frans Pop <elendil@planet.nl> writes:
> (Sorry for the late reply.)
>
> On Thursday 14 February 2008, Chris Lamb wrote:
>> This is my updated patch to support a hardware burn-in stage in D-I by
>> way of enhancing the existing cpuburn package in Debian. Please refer to
>> the original thread for justification and discussion, etc.
>
> This version looks fine.
>
> One last very minor coding style point. Please change:
> +while [ "$STATE" -ge 1 -a "$STATE" -le 3 ]; do
> to:
> +while [ "$STATE" -ge 1 ] && [ "$STATE" -le 3 ]; do
>
> As far as I'm concerned you can file the wishlist BR to implement this.
> Suggest that a link is added in the changelog to this thread for the
> convenience of FTP-masters (so that they can see it has been discussed and
> approved).
While I agree that the patch looks good, I'd like to give it a try
before acking it.
Chris, please wait a cuple of days for my ack.
- --
O T A V I O S A L V A D O R
- ---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
- ---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ <http://mailcrypt.sourceforge.net/>
iD8DBQFHvW/4LqiZQEml+FURAra6AKCVLY8d/4VKnrbAtmfP7XFI3BS1KwCfZIMA
hUecrgL6FpPpI29UsvUK0bE=
=OMA2
-----END PGP SIGNATURE-----
Reply to: