[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch to tidy up wget use, and add return=4 when 404's are seen

On Saturday 16 February 2008, Philip Hands wrote:
> I've tested this briefly, and it seems to work OK, but failed
> with a grub error (that I notice has been mentioned by other, so
> I'm currently assuming that's not related to this patch)
> First I've made preseed_fetch callable as fetch_url, so that it can
> be used outside preseeding without treading on the contents of
> /var/run/preseed.last_location

I've quickly read through the patch and there's one thing I really dislike: 
the added dependency of net-retriever on preseed-common.

I suggest to add either a script or a function library to di-utils that 
performs either the "wget_plus" or the "fetch_url" functionality. I'm not 
sure which of those 2x2 options would be the most logical.

I also wonder how this changes the logging (in syslog). If it still visible 
what the result of a wget was?

A more descriptive name for wget_plus would be nice too...


Attachment: signature.asc
Description: This is a digitally signed message part.

Reply to: