[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Support for "hardware burn-in" stage

Chris Lamb <chris@chris-lamb.co.uk> writes:

> Otavio Salvador wrote:
>> >> - I wonder if the CPU type could not be determined based
>> >> on /proc/cpuinfo
>> I think it's useful to avoid questions to users and then or we're
>> conservative and choose one generic flavour or we try to detect it.
> Thinking about it more, I guess I would prefer it detect it when run. That
> way:
>  * There are no complicated questions ("What's a K7 chip?" "Won't it
>    explode if I don't have a K7 chip?")
>  * It's easier to extend (and replace!) the actual 'burn' program.
>  * No need to preseed the CPU type and maintain different lists - it's
>    just detected.

I completely agree with you that it's much better to detect it.

>> > I agree with and have applied your
>> <...>
>> >  * XB-Installer-Menu-Item > 90000 suggestion
>> <...>
>> While I agree with Frans on that, in some ways, I also think that some
>> people would like to preseed its run and maybe it could be done
>> just before finish install.
> Not being able to preseed would be a shame, in my opinion.

I think I agree that, when it gets loaded by the user it ought to
run. That makes fairly easy to get it using preseeding.

>> It would be nice if you could send a new patch so we could build it
>> and give it a try easily.
> I have attached a new third part to be combined with the previous two. Let
> me know if I can make this easier.

Right. I think that you could wait few days to see if someone gives
any good reason to keep it out and if not, start to work on the
detection of processor and ask for review of debconf templates.

        O T A V I O    S A L V A D O R
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
"Microsoft sells you Windows ... Linux gives
 you the whole house."

Reply to: