Re: [RFC] Erase LVM/crypto issues and proposed partman reorg
Hi Frans,
On Tue, Dec 04, 2007 at 04:39:38PM +0100, Frans Pop wrote:
> > > 1) Rename current "wipe" functions
> > >
> > > For partman-crypto I have a patch that renames the existing functions
> > > to include the crypto namespace:
> > > - wipe -> crypto_do_wipe
> > > - dev_wipe -> crypto_wipe_device
> >
> > Good change, agreed. In fact I have a patch sitting here
> > that does the exact same change, among others.
>
> OK. Attached my version of the patch that also includes some other minor
> cleanups. Let me know if I should commit this or that you want to commit
> your own version. However, I will commit my version before I start on the
> reorganization (see below).
Your version seems fine, please commit. Mine is
dependent on a few other cleanups that should wait until
after the reorganization.
> > I'm willing to put in some work to help deal with the
> > implementation and fallout of this and the other proposed
> > changes, (and eventually contribute to the reimplementation
> > of the removal of crypto devices). I'm happy to set aside
> > some time this weekend and review or test changes.
>
> That's great. I don't expect much fallout, but some extra testing is always
> welcome. And help with the re-implementation is especially welcome.
>
> I will start work on this tomorrow. If anybody has any pending changes for
> partman (that are solid enough), please commit them before then.
OK. I will monitor the list and commits for anything to do.
I'll have limited time until friday, but feel free to send
anything to me directly as well, if you like.
Max
Reply to: