Re: Fwd: Bug#446994: partman-base: <go back> from first dialog no longer works

[Anton Zinoviev <anton@lml.bas.bg>]

On Wed, Nov 14, 2007 at 06:04:35PM +0100, Frans Pop wrote:
> 
> The old code was perfectly fine. You decided that it needed reorganization, 
> which is fine with me. That reorganization caused a regression. Normally 
> that means that its *your* responsibility to fix such regressions when they 
> are reported.

I understand this, Frans, but perhaps I underestimated the 
consequences...  I am sorry if I am causing inconvenience to the members 
of d-i team and I will try to test the fix I proposed as soon as 
possible.  For the future perhaps it will be a good idea if I don't 
change the code of partman directly but rather submit patches in BTS.  
While I might be able to work for partman from time to time, I have no 
right to expect from the members of d-i team to fix unnoticed 
regressions while I am unavailable.

> Pointing to others and say "try this, maybe it will fix my mistake" is 
> shifting your responsibility to others, which is not very nice.

It wasn't this the idea...  The idea was that the fix was rather simple 
(only 3 lines need to be removed), so perhaps someone might want to try 
it before I was able to test it.

> The old behavior was:
> - if that dialog is displayed when partman is first started and <go back> is
>   selected, exit to the menu
> - if that dialog is displayed after selecting "Guided partitioning" from the
>   main partman screen and <go back> is selected, return to the main partman
>   screen

At the moment I believe the change I proposed will restore the old 
behaviour.

Anton Zinoviev