[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#447326: pkgsel: add support for pre-hooks



On Sat, Oct 20, 2007 at 07:37:25PM -0400, Joey Hess wrote:
> dann frazier wrote:
> > This patch adds an /usr/lib/pre-pkgsel.d/ directory where hooks can be
> > added in a run-parts fashion. popcon handling has been factored out
> > into its own script in this directory.
> > 
> > My main motivation for this patch is that I wanted the ability to
> > install a package containing a task definition into /target just
> > before tasksel gets executed.
> 
> Couldn't you get the same effect by using apt-install in
> pressed/early_command, or in a hook in /usr/lib/base-installer.d?
> 
> Or does this need to happen after apt-setup?

Exactly. I use an apt-setup generator to add a repository that
includes my custom task package, so this must happen afterwards.

In sarge I stored the deb including the task definition in the initrd
and installed it w/ a late-command. This obviously doesn't work	now
that tasksel runs before the late-command. This revised method also
avoids the sync problem with the task definition in the initrd and the
one on the mirror.

> The patch is fine for small hooks, but doesn't advance the progress bar
> between hooks as base-installer does, so would be problimatic if any
> hooks took long.

I haven't messed w/ progress bar stuff much, but I'll look into adding
this support.

Thanks for the review.

-- 
dann frazier





Reply to: