[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] netcfg: use Choices-C for interface choices

Colin Watson wrote:
> The attached patch makes netcfg use Choices-C for interface choices
> rather than the current weird hack whereby you normally have to preseed
> the full English description of the interface but netcfg will let you
> get away with just preseeding the interface name.
> Does anyone care if preseeding the full interface description stops
> being supported? That is, you would no longer be able to say:
>   d-i netcfg/choose_interface select eth0: Ethernet or FireWire (IEEE 1394)
> ... but would always just use (as previously supported but not
> mandatory):
>   d-i netcfg/choose_interface select eth0
> I figure that the full-description syntax was liable to change anyway as
> it was constructed from the description of a debconf template.

Yes, I think this change is fine. The full description syntax is not
even documented in the manual.

> This patch is untested for now, although it does at least compile.

I ran a quick test with it, and netcfg segfaulted. I haven't looked at why.

see shy jo

Attachment: signature.asc
Description: Digital signature

Reply to: