[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFC] Add support for LUKS encrypted root in rescue mode



On Sunday 22 July 2007 13:36, Jérémy Bobbio wrote:
> This only affects rescue-mode.postinst, add a template and a dependency
> on crypto-modules and cryptsetup-udeb.

I don't really like the fact that it depends on cryptsetup udeb.
That completely destroys the concept that partman-crypto-dm and/or its 
dependencies are only loaded on demand.

IMO it would be better to
- put all the new code inside a library file in partman-crypto
- check if that file exists before sourcing it
- only loading the additional udebs (in a similar way as is done in
  partman-crypty/crypto_tools) on demand if rescue-mode is actually
  enabled
- only doing the actual activation if all these conditions have been met

Cheers,
FJP

Attachment: pgpSP_RZADAGJ.pgp
Description: PGP signature


Reply to: