[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Reworking the GTK+ cdebconf frontend

Jérémy Bobbio wrote:
On Thu, Jun 21, 2007 at 03:35:09PM +0200, Attilio Fiandrotti wrote:
I must evantually say i'm disappointed of the way the gtk frontend code was nonchalantly modified, without any patch being posted and discussed on d-boot previously, moreover proving to ignore many design decisions behind the whole g-i.

Because of all the above reasons, i'd like to revert the gtk frontend to r47287 ASAP.

My initial plan was to work on the code alone until I would be satisfied
with it and then only to submit it for inclusion.

Colin told me that it would be better if I would rather do more
incremental changes that could be more easily reviewed.  I then followed
his advice and started to commit incremental changes in the repository.

What I have done yet is only a first step in a process.  I basically
wanted to have a better view on the code to be able to refactor it.
It's currently underdocumented, so I wanted to get things clearer in the
first place.  This meant expanding variable definitions and adding a lot
of comments all over the code.  And yes, this made the code longer, but
that's only a first step to be sure that I would not loose any
subtitlities during the refactoring step.

I felt a general consensus here, in Edinburgh, from most people involved
in the debian-installer, that such improvement of the code base would be
more than welcome.  I also felt that they were trusting my intents and
my abilities to improve the code.

I know how much time you have actually spent on that code, and I fully
appreciate it.  If you don't trust me, well...  I might just go on with
my initial idea and submit a huge diff at the end.

In any case, please give me more time before rejecting my contributions
straight away.

I see you reverted recents modifications you made to the gtk frontend, thanks for doing so: aAs i said before, i think modifications introduces in 47578 and 47611 are ok, so no problem for me in reapplying again without further delays.

G-I is a complex project that many and many people contributed to over time and new contributore are not only welcome, but also needed, so welcome aboard :)

If you look at cdebconf-gtk-udeb [1] bugs page, you'll see a list of open issues regarding the g-i.

Since it looks to me you're interesting in adding new functionalities to the g-i, here is a resume of the most "implementative" still open issues

-Adding a grahical partitioner to the g-i: oswald xavier started porting gparted, C++ written, to plain C; a good codebase already exists, but the project is currently halted

-Adding a graphical terminal to the g-i: (see [2]) ATM possible options are VTE, ZVT and DFBterm

-Moving specialized handlers for countrychooser out of the GTK frontend, into an appropriate plugin (this requires, i think, also rewriting of related debconf clients)

-Developing a better handler for language chooser, pherhaps as a plugin, as right now localized languages names are displayed unaligned vertically [3]



[1] http://svn.debian.org/wsvn/d-i/trunk/packages/cdebconf/src/modules/frontend/gtk/gtk.c?op=diff&rev=47611&sc=1
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=339855
[3] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=401715

Reply to: