[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#427657: Processed: Re: Bug#427657: wrong keyboard at gui install

tags 427657 patch
retitle 427657 "Crash at VT switch in Etch and keymap not reloaded in Lenny"

Frans Pop wrote:
On Wednesday 13 June 2007 13:22, Attilio Fiandrotti wrote:
So, i assume something has changed after etch release which requires
libgcc on i386 too, right?

Yes. No idea exactly what, but I suspect gcc. directfb itself has had an upload after Etch, but that included only minor changes.
I doubt it is really worthwhile to investigate exactly what changed.

The German keyboard issue is unrelated.

So, again something has changed after etch release, which now prevents
keyboard reloading (which instead worked in etch) from working: any
clue about what it may be ?

Nope. It is nothing in D-I itself. directfb seems unlikely too.
This one is all yours.

I built to i386 installers ("build_netboot_gtk" target) from svn trunk and "etch" branch, patching both the vt crash and the keymap bugs, see below



1) *Etch installer*
- Keymap bug is not reproducible (italian keymap works perfectly)

- VT crash bug is reproducible, the patch consists in providing libgcc.so.1 via EXTRAFILES, like we did for amd64 previously (i suspect also PPC may need this workaround)

2) *Lenny installer*
- Keymap bug is reproducible: because in lenny we use gtk 2.10.x (2.8.x is instead used in etch) and GDK_WINDOWING_DIRECTFB is not defined, and because of the #ifdef's i removed in the attached patch, the code which reloads the keymap is no longer built into the gtk frontend, which consequently doesn't reload the keymap.
The attached patch should be commited in trunk only.

-VT crash bug is not reproducible because libgcc is already provided in lenny installer by some udeb
Index: cdebconf/src/modules/frontend/gtk/gtk.c
--- cdebconf/src/modules/frontend/gtk/gtk.c	(revisione 47245)
+++ cdebconf/src/modules/frontend/gtk/gtk.c	(copia locale)
@@ -49,13 +49,7 @@
 #include <debian-installer/slist.h>
 #include <gdk/gdkkeysyms.h>
-#if GTK_CHECK_VERSION(2,10,0)
 #include <directfb.h>
-#include <directfb.h>
 #define WINDOW_WIDTH 800
 #define WINDOW_HEIGHT 600
@@ -1493,14 +1487,7 @@
      * for dfb to support automatic keymap change detection and reloading
      * (See also bug #381979)
-    #if GTK_CHECK_VERSION(2,10,0)
     dfb_input_device_reload_keymap( dfb_input_device_at( DIDID_KEYBOARD ) );
-    #endif
-    #else
-    dfb_input_device_reload_keymap( dfb_input_device_at( DIDID_KEYBOARD ) );
-    #endif

Reply to: