[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r47134 - trunk/installer/build/config/m68k



On Mon, Jun 04, 2007 at 03:38:14PM +0200, Frans Pop wrote:
> On Sunday 03 June 2007 16:10, Stephen Marenka wrote:
> > Author: smarenka
> > Date: Sun Jun  3 14:10:24 2007
> > New Revision: 47134
> >
> > Log:
> > [m68k] drop keymaps that aren't at, start simplifying
> [...]
> > +++ trunk/installer/build/config/m68k/cdrom.cfg	Sun Jun  3 14:10:24
> > -EXTRANAME = cdrom/
> > +EXTRANAME = cdrom-
> [...]
> > +++ trunk/installer/build/config/m68k/hd-media.cfg	Sun Jun  3 14:10:24
> > -EXTRANAME = hd-media/
> > +EXTRANAME = hd-media-
> 
> > Author: smarenka
> > Date: Mon Jun  4 12:50:12 2007
> > New Revision: 47139
> [...]
> > +++ trunk/installer/build/config/m68k/nativehd.cfg      Mon Jun  4
> > -EXTRANAME = nativehd/
> > +EXTRANAME = nativehd-
> 
> I'm not sure that these changes are a good idea. Currently, debian-cd 
> looks in the cdrom subdir for the initrd and is thus currently broken. 
> With the new name, debian-cd would probably have to rename the initrd too 
> because the cdrom- prefix is rather meaningless on a CD.
> 
> Did you have a particular reason for these changes?
> 
> IMO it would be better, also for consistency with other arches, to keep 
> the subdirs.

No particular reason other than it seemed silly to have a directory
containing one file. I'll put it back. I'm fine with consistency -- I
was sort of striving for a bit of that with my changes anyway.

I sort of forgot about debian-cd, although I don't believe it's
currently building anything for m68k. I hope to look at that soonish.

Thanks,

Stephen

-- 
Stephen R. Marenka     If life's not fun, you're not doing it right!
<stephen@marenka.net>

Attachment: signature.asc
Description: Digital signature


Reply to: