[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#426737: lilo-installer fails on HP SmartArray controllers (/dev/ida)



Package: lilo-installer
Version: 1.20

During installation of Debian Etch, lilo-installer fails when using
/dev/ida/c0d0 (Compaq/HP SmartArray) as boot/root device.

The reason are some checks in lilo-installer.postinst that assume that
the device has to look like /dev/[hs]d[a-z].

However, SmartArray controllers use device-names like /dev/ida/c0d0
(/dev/cciss/c0d0 on Ubuntu) and partition names like /dev/ida/c0d0p1 (or
/dev/cciss/c0d0p1).

The attached patch fixes this issue.

I've also reported this bug at Ubuntu launchpad some time ago:
https://bugs.launchpad.net/ubuntu/+source/lilo-installer/+bug/103291

--leo

P.S.: Note that the patch only fixes installation in the MBR, installing
lilo in a partition would need further fixes.



--- lilo-installer.postinst.orig	2007-04-05 10:56:58.882464035 +0200
+++ lilo-installer.postinst	2007-04-05 11:03:42.144421696 +0200
@@ -53,14 +53,15 @@
 
 bootfs=$(mapdevfs $bootfs_devfs)
 
-prefix=$(echo "$bootfs_devfs" | sed 's/\(\/dev\/[a-z]\+\).*/\1/')
+prefix=$(echo "$bootfs_devfs" | \
+  sed 's/\(\/dev\/\(cciss\|ida\)\/c[0-9]d[0-9]\|\/dev\/[a-z]\+\).*/\1/')
 
 case $prefix in
 	/dev/md)
 		disc_offered_devfs="$bootfs_devfs"
 		db_register lilo-installer/bootdev_raid lilo-installer/bootdev
 	;;
-	/dev/[hs]d[a-z])
+	/dev/[hs]d[a-z]|/dev/cciss/c[0-9]d[0-9]|/dev/ida/c[0-9]d[0-9])
 		disc_offered_devfs="$prefix"
 	;;
 	*)
@@ -136,7 +137,8 @@
 
 # If installing to a partition (not MBR), offer to make it active
 # Do not try to make MD device active
-if (echo "${bootdev}" | grep -q '[0-9]$') && [ "${raid_boot}" = "no" ]; then
+if (echo "${bootdev}" | grep -v '/c[0-9]d[0-9]$' | grep -q '[0-9]$') \
+  && [ "${raid_boot}" = "no" ]; then
     # Installing to a partition, check if it is already marked active
     if ! fdisk -l ${disc_offered_devfs} | grep "^/dev[a-z0-9/]\+\(part\|[hs]d[a-z]\)${part} " | grep -q '\*'; then
         # partition is not marked active, offer to make it so

Reply to: