On Sunday 27 May 2007 21:04, Joey Hess wrote: > I don't see the need for a subdir myself, the /etc is small and already > contains d-i configuration items such as /etc/preseed_aliases. OK. I'll adjust the patches to implement this and upload net-retriever. > > Do we really want to keep the hardcoded value in mirrors.h? If it's > > no longer used, we are sure to forget to update it at some point. IMO > > failing with an error in the syslog would be better in the long run. > > It's still used, it falls back to the suites in the list if the > preferred one is somehow not present. Yeah, but having the hardcoded #define PREFERRED_DISTRIBUTION "lenny" at the top of the suites array does not make any sense and that define is redundant with this scheme in place. It is forgetting to update that define in the future that I'm worried about. And an old value for that combined with a build issue that causes the new file to be missing could send us on a wild goose chase. But the use of the suites array in mirror.h should change anyway if my proposal in #418382 should get implemented...
Description: PGP signature