[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r45943 - in trunk/packages/partman: partman-auto partman-auto-lvm partman-auto-lvm/debian partman-auto/debian



On Sunday 18 March 2007 14:11, David Härdeman wrote:
> Modified: trunk/packages/partman/partman-auto/auto-shared.sh
> =======================================================================
> --- trunk/packages/partman/partman-auto/auto-shared.sh (original)
> +++ trunk/packages/partman/partman-auto/auto-shared.sh Sun Mar 18
> @@ -84,10 +84,13 @@ 
>  }
>
>  wipe_disk() {
> -	cd $dev
> +	local dev
> +	dev="$1"
>
>  	lvm_wipe_disk "$dev" || return 1
>
> +	cd $dev
> +
>  	open_dialog LABEL_TYPES
>  	types=$(read_list)
>  	close_dialog

Shouldn't this include a test that $1 is not empty and that $dev is a 
valid disk (i.e. that 'cd $dev' succeeds)?

Attachment: pgp6JSP_3b9zv.pgp
Description: PGP signature


Reply to: