[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#408297: should honor mirror/*/proxy when fetching keys for local repositories

tags 408297 + pending

On Wednesday 24 January 2007 17:55, John Morrissey wrote:
> It seems mirror/*/proxy isn't being honored when fetching the key,
> since the environment variable http_proxy isn't being set before
> wget(1) is called.

Thanks for your suggested patch. There were some minor problems with it, 
so we have modified it slightly. I've committed the following patch in 
our SVN repository:

--- generators/60local  (revision 44465)
+++ generators/60local  (working copy)
@@ -32,6 +32,12 @@
                echo "deb-src $repository" >> $file
        if [ -n "$key" ]; then
+               # make wget use the proxy
+               protocol=${repository%%:*}
+               if db_get mirror/$protocol/proxy && [ "$RET" ]; then
+                       proxy="$RET"
+                       eval "export ${protocol}_proxy=$proxy"
+               fi
                # fetch the key
                wget "$key" -O "$ROOT/tmp/key$i.pub"
                # add it to the keyring

Main changes are:
- the way protocol is determined
- make sure we only set the proxy if it is defined in debconf database
- that the variable exported now depends on the protocol (http/ftp_proxy)

Could you test this patch before we upload it?
You can easily test it by just editing (using nano) the 60local file in
/usr/lib/apt-setup/generators before apt-setup is run.


Attachment: pgpHBDc4k_LtZ.pgp
Description: PGP signature

Reply to: