--- Begin Message ---
package: cdebconf-gtk-udeb
severity: minor
tags: patch
Currently the screenshot and cancel buttons are setup sensitive in
gtk_initialize(), so if a long time should pass between
frontend_intialize()
and frontend_go(), the user may be able to click them.
As the gtk_main() loop is already running there should be no risk of
crashing anything, but anyway this patch disables those buttons in
gtk_initialize(), like it's already done for back and cancel buttons.
Hiding them, as it's done now, has no effect, and this should be fixed
because it's wrong.
The attached patch also takes care of hiding ok, back and screenshot
buttons while the progressbar is running and CAPB progresscancel is not
set (it makes no sense, IMHO, displaying disabled buttons)
cheers
Attilio
Index: gtk.c
===================================================================
--- gtk.c (revisione 42838)
+++ gtk.c (copia locale)
@@ -1315,11 +1315,12 @@
gtk_button_box_set_layout (GTK_BUTTON_BOX(actionbox), GTK_BUTTONBOX_END);
gtk_box_set_spacing (GTK_BOX(actionbox), DEFAULT_PADDING);
- /* button to take screenshots of the frontend */
+ /* Screenshot button is set insensitive by default */
button_screenshot = gtk_button_new_with_label (get_text(obj, "debconf/gtk-button-screenshot", "Screenshot"));
g_signal_connect (G_OBJECT (button_screenshot), "clicked", G_CALLBACK (screenshot_button_callback), obj );
gtk_box_pack_start (GTK_BOX(actionbox), button_screenshot, TRUE, TRUE, DEFAULT_PADDING);
((struct frontend_data*) obj->data)->button_screenshot = button_screenshot;
+ gtk_widget_set_sensitive (button_screenshot, FALSE);
/* Here are the back and forward buttons */
button_prev = gtk_button_new_with_label (get_text(obj, "debconf/button-goback", "Go Back"));
@@ -1344,7 +1345,7 @@
gtk_widget_set_sensitive (button_prev, FALSE);
gtk_widget_set_sensitive (button_next, FALSE);
- /* Cancel button is not displayed by default */
+ /* Cancel button is set insensitive by default */
button_cancel = gtk_button_new_with_label (get_text(obj, "debconf/button-cancel", "Cancel"));
ret_val = NEW(int);
*ret_val = DC_GOBACK;
@@ -1353,7 +1354,7 @@
G_CALLBACK(cancel_button_callback), obj);
gtk_box_pack_start (GTK_BOX(actionbox), button_cancel, TRUE, TRUE, DEFAULT_PADDING);
((struct frontend_data*) obj->data)->button_cancel = button_cancel;
- gtk_widget_hide(button_cancel);
+ gtk_widget_set_sensitive (button_cancel, FALSE);
/* focus order inside actionbox */
focus_chain = g_list_append(focus_chain, button_next);
@@ -1679,13 +1680,14 @@
gtk_widget_hide(data->button_prev);
gtk_widget_hide(data->button_next);
gtk_widget_show(data->button_cancel);
+ gtk_widget_set_sensitive (data->button_cancel, TRUE);
GTK_WIDGET_SET_FLAGS (GTK_WIDGET(data->button_cancel), GTK_CAN_DEFAULT);
gtk_widget_grab_default (GTK_WIDGET(data->button_cancel));
}
else {
- gtk_widget_set_sensitive (data->button_screenshot, FALSE);
- gtk_widget_set_sensitive (data->button_prev, FALSE);
- gtk_widget_set_sensitive (data->button_next, FALSE);
+ gtk_widget_hide(data->button_screenshot);
+ gtk_widget_hide(data->button_prev);
+ gtk_widget_hide(data->button_next);
gtk_widget_hide(data->button_cancel);
}
--- End Message ---
--- Begin Message ---
Source: cdebconf
Source-Version: 0.110
We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:
cdebconf-gtk-udeb_0.110_amd64.udeb
to pool/main/c/cdebconf/cdebconf-gtk-udeb_0.110_amd64.udeb
cdebconf-newt-udeb_0.110_amd64.udeb
to pool/main/c/cdebconf/cdebconf-newt-udeb_0.110_amd64.udeb
cdebconf-priority_0.110_all.udeb
to pool/main/c/cdebconf/cdebconf-priority_0.110_all.udeb
cdebconf-text-udeb_0.110_amd64.udeb
to pool/main/c/cdebconf/cdebconf-text-udeb_0.110_amd64.udeb
cdebconf-udeb_0.110_amd64.udeb
to pool/main/c/cdebconf/cdebconf-udeb_0.110_amd64.udeb
cdebconf_0.110.dsc
to pool/main/c/cdebconf/cdebconf_0.110.dsc
cdebconf_0.110.tar.gz
to pool/main/c/cdebconf/cdebconf_0.110.tar.gz
cdebconf_0.110_amd64.deb
to pool/main/c/cdebconf/cdebconf_0.110_amd64.deb
libdebconfclient0-dev_0.110_amd64.deb
to pool/main/c/cdebconf/libdebconfclient0-dev_0.110_amd64.deb
libdebconfclient0-udeb_0.110_amd64.udeb
to pool/main/c/cdebconf/libdebconfclient0-udeb_0.110_amd64.udeb
libdebconfclient0_0.110_amd64.deb
to pool/main/c/cdebconf/libdebconfclient0_0.110_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 400124@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Frans Pop <fjp@debian.org> (supplier of updated cdebconf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 11 Dec 2006 01:13:33 +0100
Source: cdebconf
Binary: cdebconf-slang-udeb libdebconfclient0 cdebconf-priority cdebconf libdebconfclient0-dev cdebconf-udeb libdebconfclient0-udeb cdebconf-gtk-udeb cdebconf-text-udeb cdebconf-newt-udeb
Architecture: source amd64 all
Version: 0.110
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
Description:
cdebconf - Debian Configuration Management System (C-implementation)
cdebconf-gtk-udeb - Gtk+ frontend for Debian Configuration Management System (udeb)
cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
cdebconf-priority - Change debconf priority (udeb)
cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
libdebconfclient0 - Debian Configuration Management System (C-implementation)
libdebconfclient0-dev - Development files for cdebconf
libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 400124 401871
Changes:
cdebconf (0.110) unstable; urgency=low
.
[ Attilio Fiandrotti ]
* Create buttons in GTK frontend inactive and hide them while the
progressbar runs. Closes: #400124.
* Avoid crash in GTK frontend in some cases during language selection.
Closes: #401871.
.
[ Colin Watson ]
* Restore newt progress bar refactoring, this time with an extra tweak to
tear down the old progress bar if you attempt to start a nested progress
bar. (Don't do that; it's not supported and trying to use the outer
progress bar after stopping the inner one will result in cdebconf
silently sitting there at a black screen. However, partman-auto does
this at the moment. See #391676.)
.
[ Petter Reinholdtsen ]
* Remove myself as uploader.
.
[ Updated translations ]
* Belarusian (be.po) by Pavel Piatruk
* Basque (eu.po) by Piarres Beobide
* Kurdish (ku.po) by Erdal Ronahi
* Latvian (lv.po) by Aigars Mahinovs
* Malayalam (ml.po) by Praveen A
* Panjabi (pa.po) by A S Alam
Files:
88f2ea145bd75266f5831916bdb49b69 1178 utils optional cdebconf_0.110.dsc
d63852037dacc2b2d49a62205d53130f 231531 utils optional cdebconf_0.110.tar.gz
51835c610fc79d9930a4c0b9614f3382 2678 debian-installer standard cdebconf-priority_0.110_all.udeb
82e283fb3802b183319dfc1d79b80ca7 151708 utils extra cdebconf_0.110_amd64.deb
3246c5e26db138a00ef47cb45752da27 32476 libs optional libdebconfclient0_0.110_amd64.deb
a67e4bbe8d2ca73e907b7e12a8806d6b 33534 libdevel optional libdebconfclient0-dev_0.110_amd64.deb
ada00dc7dadf9cc4bba833ae4e7bc0b0 73046 debian-installer standard cdebconf-udeb_0.110_amd64.udeb
39db09772777cb5828daee56d89df8ba 3250 debian-installer optional libdebconfclient0-udeb_0.110_amd64.udeb
b504a364e613d03c3c1903ba40ab3eb4 17864 debian-installer optional cdebconf-newt-udeb_0.110_amd64.udeb
faac2803541f13fbfa3728ebf95fde4b 18994 debian-installer optional cdebconf-text-udeb_0.110_amd64.udeb
24e7a6a00ce626a9ab434fdb0ea39117 23992 debian-installer optional cdebconf-gtk-udeb_0.110_amd64.udeb
Package-Type: udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFFfKNagm/Kwh6ICoQRAi4DAJ9/2GFWKbt0XlzoTsABk30G7i4B4QCgsDrs
yvjt8FLiAkw/T9yMULa9gL4=
=C2if
-----END PGP SIGNATURE-----
--- End Message ---