[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#394970: Please, add credits for patch while closing #394970



Hi Frans,

* 2006-11-30 18:33, Frans Pop wrote:
> On Thursday 30 November 2006 18:02, Fabio Tranchitella wrote:
> >   do you mind to retroactively modify the changelog for the upload 2.6
> > of finish-install to credit Sven Luther about the patch he submitted? I
> > do not want to be pedantic, and I know that you modified and fixed his
> > patch, but I think it would be correct considering that in the same
> > changelog entry you already cite the names of the translators who
> > submitted the updates.
> 
> No sorry.
> The patch that was applied was not Sven's patch, but a patch I basically 
> created myself from scratch. Sven's patch was broken (/etc/inittab would 
> not have had the correct line) and had unnecessary code duplication (as 
> he indicated himself).

Fine, thanks for your explanation: I now understand your reasons, and I
accept it.

> credit people just for submitting a bug report.

That's normal.

> Sven has always been correctly credited for any patches he's submitted or 
> work he's contributed.

Thanks for confirming this, too.

Have a nice day,

-- 
Fabio Tranchitella                         http://www.kobold.it
Free Software Developer and Consultant     http://www.tranchitella.it
_____________________________________________________________________
1024D/7F961564, fpr 5465 6E69 E559 6466 BF3D 9F01 2BF8 EE2B 7F96 1564

Attachment: signature.asc
Description: Digital signature


Reply to: