Bug#398333: Automatic partition/disk selection
On Thu, Nov 23, 2006 at 02:48:13PM +0100, Frans Pop wrote:
On Friday 17 November 2006 11:28, David Härdeman wrote:
On Fri, November 17, 2006 10:21, Frans Pop said:
> Because the method is not a question as such when using preseeding.
> We should handle the situation where partman-auto/disk is preseeded
> but partman-auto/method is not more gracefully though.
How would you like it to work?
I think we have two options:
1) Default to method "regular"
If partman-auto/disk=/dev/* and partman-auto/method is not set, then
default partman-auto/method to "regular".
2) Error out if no method set
If partman-auto/disk=/dev/* and partman-auto/method is not set, then show
an error message and unset partman-auto/disk.
I somewhat prefer 1) as it gives some backwards compatibility and 2)
probably would mean adding a new error message which is undesirable for
RC2.
Said and done, patch attached for review.
--
David Härdeman
Index: debian/changelog
===================================================================
--- debian/changelog (revision 42849)
+++ debian/changelog (working copy)
@@ -5,8 +5,12 @@
is needed for installations on systems with 32 MB RAM and only a 1 GB
drive. Closes: #399951.
- -- Martin Michlmayr <tbm@cyrius.com> Thu, 23 Nov 2006 18:51:38 +0100
+ [ David Härdeman ]
+ * Use regular autopartition method if partman-auto/method has not been
+ set but partman-auto/disk has. Closes: #398333.
+ -- David Härdeman <david@hardeman.nu> Thu, 23 Nov 2006 22:29:54 +0100
+
partman-auto (60) unstable; urgency=low
[ Updated translations ]
Index: init.d/initial_auto
===================================================================
--- init.d/initial_auto (revision 42849)
+++ init.d/initial_auto (working copy)
@@ -38,6 +38,9 @@
if db_get partman-auto/method && [ -n "$RET" ]; then
method="$RET"
fi
+if [ -n "$method" ]; then
+ method="regular"
+fi
# See if any autopartition disks have been set
disks=""
Reply to: