[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r42716 - in trunk/installer: build/config build/config/powerpc build/config/powerpc/prep build/pkg-lists/cdrom build/pkg-lists/netboot debian doc/devel

On Wed, Nov 22, 2006 at 08:33:35PM +0100, Frans Pop wrote:
> On Wednesday 22 November 2006 19:50, Frans Pop wrote:
> > Obviously prep used to be a subarch at this level together with chrp.
> > Looking at powerpc/prep.cfg, I see no reason why the old solution was
> > abandoned here.
> Hmm. The reason could be that prep now has a separate kernel flavor where 
> it did not have one previously.
> In that case the following patch should probably be applied to clean 
> things up a little:
> Index: prep.cfg
> ===================================================================
> --- prep.cfg    (revision 42772)
> +++ prep.cfg    (working copy)
> @@ -6,8 +6,6 @@
>  KERNELNAME = vmlinux
> -SUBARCHES = prep
> -
>  cd_content: cd_content_common
>  netboot_content: netboot_content_common
> Index: powerpc.cfg
> ===================================================================
> --- powerpc.cfg (revision 42772)
> +++ powerpc.cfg (working copy)
> @@ -6,7 +6,7 @@
>  KERNELNAME = vmlinux
> -SUBARCHES = chrp # prep coff ppcbug
> +SUBARCHES = chrp # coff ppcbug
>  cd_content: cd_content_common

Another clueless comment.

Naturally, since you didn't understand what the SUBARCHES variable is used
for, and didn't bother to check, you had no chance to understand what is going
on here. Please leave that code alone, and leave it to folk who actually
understand what is going on on powerpc. Would be easier if you had not
actually unfairly outcast the most active of them.

The current code is perfectly fine as it is, altough your second hunk, altough
cosmetic could be valid.

The first hunk breaks prep support though, which needs the mkvmlinuz build
vmlinuz with builtin initrd, since it cannot boot a plain elf vmlinux and
separate initrd.gz, since neither yaboot nor grub2 boots on it.

Just give my commit access back, and let me handle the powerpc port, instead
of persisting in your spoiled child revenge, and try to dabble in something
where you are both clueless and uninterested.

Sven Luther

Reply to: