Re: r42716 - in trunk/installer: build/config build/config/powerpc build/config/powerpc/prep build/pkg-lists/cdrom build/pkg-lists/netboot debian doc/devel
On Wed, Nov 22, 2006 at 07:50:37PM +0100, Frans Pop wrote:
> On Saturday 18 November 2006 22:17, Martin Michlmayr wrote:
> > Modified: trunk/installer/build/config/powerpc.cfg
> > ==============================================================================
> > --- trunk/installer/build/config/powerpc.cfg (original)
> > +++ trunk/installer/build/config/powerpc.cfg Sat Nov 18 22:17:56 2006
> > @@ -1,4 +1,4 @@
> > -SUBARCH_SUPPORTED = powerpc powerpc64 # apus
> > +SUBARCH_SUPPORTED = powerpc powerpc64 prep # apus
> >
> > KERNELMAJOR = 2.6
>
> I wonder why prep is promoted to a general subarch here rather than
> a subarch for powerpc only as it was previously.
Because, as i have told already in the past, prep didn't make the ARCH=powerpc
switch upstream, so has to build with ARCH=ppc, so is using a different kernel
flavour.
> config/powerpc/powerpc.cfg has:
> SUBARCHES = chrp # prep coff ppcbug
Mmm, i don't know about this one, need to check, but my checked out tree is
again in a messy state with load of conflicts.
The SUBARCHES variable is only used for mkvmlinuz invocation though, and you
cannot really make any conclusion about what is listed there.
> Obviously prep used to be a subarch at this level together with chrp.
> Looking at powerpc/prep.cfg, I see no reason why the old solution was
> abandoned here.
>
> If a change does need to be made, it probably makes sense to rename the
> current "powerpc" subarch to "chrp".
> However, I think that the old setup is probably fine and that this is just
> carelessness in the patch. I'll revert to the old setup if there are no
> objections.
You clearly have no clue, so i wonder why you question the patch ? Go and ask
Colin or someone else with a clue or look at the code, since it is clear you
don't thrust me.
Sven Luther
Reply to: