[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#393919: partman-crypto: should provide separate short description

On Sun, Oct 22, 2006 at 05:30:55PM +0200, Max Vozeler wrote:
> Using just the device name as you described seems very practical and
> I think actually solves this problem. The device name is mentioned
> in the humandev string of the encrypted device, so it can be asso-
> ciated easily. I'm currently testing a patch like the attached which
> puts string like "loop0" or "sda5_crypt" in the last column. Will
> followup once I've confirmed that it works.

This is what it looks like:

> Index: update.d/crypto_visuals
> ===================================================================
> --- update.d/crypto_visuals	(Revision 41879)
> +++ update.d/crypto_visuals	(Arbeitskopie)
> +cryptdev_shortname ()
> +{
> +	case "$1" in
> +	/dev/loop*)
> +		n=${1#/dev/loop}
> +		n=${n#/}
> +		echo "loop${n}"
> +		;;
> +	/dev/mapper/*)
> +		echo "${1#/dev/mapper}"
   		echo "${1#/dev/mapper/}"

I've made this minor adjustment to the patch (stripping an
superflous slash for /dev/mapper/ devices). Otherwise it is tested
and working as expected. I think the change is low-risk. Do you
reckon this is OK to commit wrt the rc1 commit-freeze? 


Reply to: