[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#385150: Tests with PPPoE connection

tag 384121 patch
tag 385150 patch

On 27/09/06, Gregory Colpart <reg@evolix.fr> wrote:
On Tue, Sep 19, 2006 at 02:34:57PM +0300, Eddy Petri??or wrote:
> Please do test without the "|| true" code attached to apt-install and
> with the db_stop line removed or commented out.
> I expect this to be the correct fix, and, as explained above, the "||
> true" being a lucky way out in some cases.

Result is red debconf screen because failure.
See _complete_ log here:

Yeap, that is correct :-D . Ok, I looked over the apt-install code and
saw that apt-install will return 1 is the package is queued fr
installation, a thing which is perfectly acceptable for ppp :-D.

I have attached a patch that should be applied over the current source
ppp package and should fix both #385150 and #384121. I attached also
the resulted ppp-udeb.postinst file after the patching (which should
improve testing efficiency, since it can be transfered to the test
machine via netcat).

People who wish to test the new changes can grab the postinst attached
and copy it via netcat (nc) in the installation environment (still the
plugin moving is needed) over the original one.

> >If you have other tests with PPPoE/d-i, say me.
> I know that last time I tested the package, the installation on the
> target system was not good enough and after the first reboot, although
> the ppp package was installed, the pppoe connection was not working.
> I _know_ this may be impossible for you to test, since you might not
> have a spare machine or a spare partition, so I won't mind if you can't
> do it. But, please, tell me if you can't do this test.

Indeed I have no spare partition to test complete d-i with PPPoE
and first reboot. I will *try* to have a new disk to test it next

Thanks a lot for that.

P.S.: The current ppp-udeb todo list is also attached, it would be
nice to have it in the ppp source package.

"Imagination is more important than knowledge" A.Einstein

Attachment: ppp-udeb_more_fixes.patch
Description: Binary data

Attachment: ppp-udeb.postinst
Description: Binary data

Attachment: ppp-udeb.todo
Description: Binary data

Reply to: