[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#384481: marked as done (debian-installer: current netboot and mini.iso images do not run tasksel)



Your message dated Thu, 24 Aug 2006 14:41:36 -0400
with message-id <[🔎] 20060824184136.GA23006@kitenet.net>
and subject line pkgsel postinst broken; reverted
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: debian-installer
Severity: normal

During installation with (at least) current netboot and mini.iso images
tasksel is not run, so it is not possible to select any tasks, and
default language tasks are not installed.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.18-rc4-me
Locale: LANG=uk_UA.UTF-8, LC_CTYPE=uk_UA.UTF-8 (charmap=UTF-8)


--- End Message ---
--- Begin Message ---
Recent changes to pkgsel caused #384481: It no longer ran tasksel at all.

<eugen> what is value of "(db_fget tasksel/first seen && [ "$RET" = false ]) || (db_get tasksel/first && [ "$RET" ])" if tasksel/first does not exist?
<joeyh> eugen: otavio put that in so that it can be preseeded to nothing to avoid running tasksel at all
<joeyh> is it broken?
<eugen> joeyh:  tasksel/first does not exist during normal install, so I think it evaluates to false, and so tasksel is not run

I've reverted the entire set of recent changes to the postinst, back to 
r39391. I hope that the logic can be fixed and these changes put back in,
but please *test* it this time, ok?

AFAICS, this fails because tasksel/first is not in cdebconf unless
preseeded. So both the db_fget and the db_get return nonzero, as eugen
says.

I don't have on hand the test that I originally suggested you use, but
I think that it took this case into account. Probably something like:

if ! db_fget tasksel/first seen || [ "$RET" = false ] || (db_get tasksel/first && [ "$RET" ])"; then

Which is, again, untested, and should not be committed to svn/released
until it has been tested.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


--- End Message ---

Reply to: