Re: Status of LVM/RAID in d-i?

[David Härdeman <david@2gen.com>]

On Wed, June 14, 2006 11:40, Frans Pop said:
> I'm just looking at the changes in LVM and RAID and I'm wondering what the
> status is. How well has the new code been tested?

I tested it until I could find no more bugs before I committed it to SVN.
I also posted to the list asking for review and comments before
committing. The changes for partman-lvm (essentially rewriting and merging
lvm-tools.sh from lvmcfg into partman-lvm) were fairly large, so I'm not
that surprised that bugs would be found.

> A fairly quick test using the current daily for LVM shows at least three
> important errors. As we will now be moving towards a new beta release, it
> would be nice to have things stable again fairly quickly.

I've been on vacation for a couple of days, I'll try to take a look at the
bugs later today

> 1. partman-auto-lvm no longer works
> If I choose that option there is no error, but nothing actually happens.
> After some time the main partitioning screen is shown, but no new
> partitions have been created.
>
>
> 2. test for existing physical volume name is broken
> After entering a name for a physical volume I always get a screen saying
> the name is already in use.
> The problem seems to be in this code in choose_partition/lvm/do_option:
>         # Check whether the VG name is already in use
>         if vgs "$vg" > /dev/null 2>&1; then
>                 db_set partman-lvm/vgcreate_nameused "false"
>                 db_input high partman-lvm/vgcreate_nameused
>                 db_go
>                 return
>         fi
>
> If I try that test from the console:
> # vgs newname
>   Volume group "newname" not found
> # echo $?
> 0

Curious, I seem to recall testing this last week. Perhaps I used a
different version of the lvm tools since I use unstable as the d-i suite
for my testing images. Anyways, I'll take a look at it

> I also wonder if the templates asking for the VG name and showing this
> error should not be "critical" as no default exists.

That was from the old partman-lvm code, I'll change it

> I would expect there are probably other, similar errors in the code.

Not sure what your point is...?

> 3. formatting error on confirmation screen for partition changes
> The header "The following partitions..." is misaligned.
> See: http://people.debian.org/~fjp/d-i/partman-lvm_confirm.png

I'll fix

Regards,
David