Frans Pop wrote: > On Thursday 27 April 2006 20:38, Robert Millan wrote: > > I'm attaching a patch that adds support for kernel of FreeBSD. > > > > It's very non-intrusive. Only two scripts are modified minimaly. > > There's two things I think should be improved. > - in commands/copy-modules an if statement is added without increasing the > indentation of lines between the if and fi > - in commands/install-files the current "else" condition is changed into > an "elseif" and the kfreebsd case is left as a cach-all "else" case; > it seems more logical to me to have the kfreebsd case as a special > condition instead or maybe have all cases specified and to throw an > error if none of them match Agreed. Also, I don't understand this part of the patch: - match="$(find $moddir/kernel $moddir \ + match="$(find `ls -d $moddir/kernel 2>/dev/null` $moddir \ -- see shy jo
Attachment:
signature.asc
Description: Digital signature