Hello, Attilio Fiandrotti <fiandro@tiscalinet.it> wrote: Message-ID: <[🔎] 43D23247.1040901@tiscalinet.it> > > I built mini.iso with gtk+ 2.8.10 and patches attached to this mail, > > and took some screenshots. If we does not change /etc/gtk-2.0/gtkrc > > from localechooser, glyphs are taken from improper fonts. > > so i suppose that we should definitely check in the gtk_reparse_all() > patch so that gtkrc file is reloaded every time a question is diplayed. Yes. > maybe the localechooser patch has to be extended to solve similar issues > for arabic and persian languages? I think so. But I'm not familiar with Arabic nor Persian language, so I took 8 screen shots. Without nazli.ttf (from ttf-farsiweb) and without localechooser patch, ae_AlMohanad.ttf is used in Persian[2]. With nazli.ttf and without localechooser patch, Persian is displayed with nazli.ttf[4]. But Arabic is displayed with nazli.ttf too[3]. With both nazli.ttf and localechooser patch, ae_AlMohanad.ttf is used in Arabic[5], and nazli.ttf in Persian[6]. I think [5] and [6] may look correct. Could anyone review them? 1. http://hp.debian.or.jp/~tyuyu/debian-installer/Arabic_without_nazli_without_localechooser_patch.jpg 2. http://hp.debian.or.jp/~tyuyu/debian-installer/Persian_without_nazli_without_localechooser_patch.jpg 3. http://hp.debian.or.jp/~tyuyu/debian-installer/Arabic_with_nazli_without_localechooser_patch.jpg 4. http://hp.debian.or.jp/~tyuyu/debian-installer/Persian_with_nazli_without_localechooser_patch.jpg 5. http://hp.debian.or.jp/~tyuyu/debian-installer/Arabic_with_nazli_with_localechooser_patch.jpg 6. http://hp.debian.or.jp/~tyuyu/debian-installer/Persian_with_nazli_with_localechooser_patch.jpg > Note that the standard gtkrc file will have to have this structure > > gtk-theme-name = "current theme" > gtk-font-name="current font" > > We must preserve the theme line when we overwrite the gtkrc file, so i > think the localechooser patch should be modified like this or similar I agreed. We should preserve the theme information. Best regards, -- Hidetaka Iwai tyuyu@debian.or.jp
Index: localechooser =================================================================== --- localechooser (revision 34257) +++ localechooser (working copy) @@ -278,6 +278,33 @@ esac fi +# store the current theme name to restore it later +CURRENT_THEME=$(grep gtk-theme-name /etc/gtk-2.0/gtkrc) + +# set the primary font accroding to $LANGUAGE +if [ "$DEBIAN_FRONTEND" = "gtk" ]; then + case "$LANGUAGE" in + ja) + echo 'gtk-font-name = "Sazanami Gothic 12"' > /etc/gtk-2.0/gtkrc + ;; + zh) + echo 'gtk-font-name = "AR PL ShanHeiSun Uni 12"' > /etc/gtk-2.0/gtkrc + ;; + ko) + echo 'gtk-font-name = "UnDotum 12"' > /etc/gtk-2.0/gtkrc + ;; + ar) + echo 'gtk-font-name = "ae_AlMohanad 12"' > /etc/gtk-2.0/gtkrc + ;; + fa) + echo 'gtk-font-name = "Nazli 12"' > /etc/gtk-2.0/gtkrc + ;; + esac + + # restoring the current theme information + echo $CURRENT_THEME >> /etc/gtk-2.0/gtkrc +fi + # BEGIN COUNTRY SELECTION # This is needed later in the script
Attachment:
pgp9WhcYlNFHz.pgp
Description: PGP signature