[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#249755: doesn't detect ext2 revision 0 file system

On Sun, Jan 15, 2006 at 10:03:08AM +0000, Martin Michlmayr wrote:
> * Anton Zinoviev <anton@lml.bas.bg> [2006-01-15 09:09]:
> > 3. Change partman-ext2r0/valid_filesystems/ext2r0 to expect ext2
> >    instead of ext2r0 in $id/detected_filesystem:
> > 
> > 	    [ -f $id/detected_filesystem -a -f $id/detected_ext2r0 ] \
> > 	    && [ "$(cat $id/detected_filesystem)" = ext2 ]
> > 	then
> > 	    echo ext2r0
> Won't this mean that ext2 is always identified as ext2r0, even if it's
> revision 1.  Maybe a tune2fs call should be added it.

The idea is that the file $id/detected_ext2r0 exists only if the
revision is 0.

> In any case, I cannot really evaluate the merits and downsides of
> these three different proposals.  Can you please apply the one you
> think is best to SVN and I'll test it.

Currently I don't have working testing environment for partman so I'd
better not dare to commit the changes myself.  Because of that the
only valuable merits and downsides are what you fill you will be able
to test.  You can apply my first proposal as it is a very little
modification of you original proposal (I do not like to contaminate
the basic partman package with specific knowledge about particular
filesystems).  Or if you think you will be able to test the second
proposal you can try - it is better.

Anton Zinoviev

Reply to: