[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r32476 - trunk/packages/user-setup/debian



Christian Perrier wrote:
> Author: bubulle
> Date: Sun Nov 27 22:17:24 2005
> New Revision: 32476
> 
> Modified:
>    trunk/packages/user-setup/debian/rules
> Log:
>    [ Colin Watson ]
>    * Fix clearing of encrypted user passwords from the debconf database.
>    * Remove a few bits of dead code.
>    * Exit with code 10 to back up to main menu, not 30.
>    * Use a prebaseconfig script and prompt the user earlier
>    * Remove some unnecessary calls to chroot.
>    * Simplify state machine so that one fewer line has to be changed when
>      adding or removing states.
>    [ Christian Perrier ]
>    * Add a main menu title
>    * Add a template for the prebaseconfig progress bar
>    * Removed useless and harmful db_settitle in user-setup

?

> Modified: trunk/packages/user-setup/debian/rules
> ==============================================================================
> --- trunk/packages/user-setup/debian/rules	(original)
> +++ trunk/packages/user-setup/debian/rules	Sun Nov 27 22:17:24 2005
> @@ -12,7 +12,7 @@
>  	dh_testdir
>  	dh_testroot
>  	dh_clean -k
> -	dh_install
> +	dh_install -X\.svn

The \ is not necessary, and the -X.svn should not be necessary either.
Either --

1. Build from a svn export tree which doesn't have the pesky .svn
   directories.
2. Use the support that is in debhelper and dpkg-dev to exclude all .svn
   directories automatically and can with some work be done for all your
   package builds (DH_ALWAYS_EXCLUDE=CVS:.svn and 
   dpkg-buildpackage -i -ICVS -I.svn)
3. Get broken packages sometimes and patch them up imprefectly after the
   fact with -X.svn that can easily miss stuff.

IMHO that's in sharply declining order of preference and 3 is below the
line of useful changes.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: