[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#334544: mklibs: Patch to reduce number of rlibs in ld calls



Package: mklibs
Version: 0.1.17
Severity: minor
Tags: patch

The attached patch makes sure a path to libraries in --root is only 
included once. Currently the same path may be included multiple times.
This significantly reduces the length of the command line when gcc is 
called to actually reduce a library.

During tests using mklibs while building the gtk-miniiso for d-i, this 
resulted in only 4 instead of 31 paths being included.

--- /usr/bin/mklibs	2005-10-14 10:03:03.000000000 +0200
+++ mklibs	2005-10-18 00:39:28.920890609 +0200
@@ -325,9 +325,11 @@
     rpath_val = rpath(obj)
     if rpath_val:
         if root:
-            if debuglevel >= DEBUG_VERBOSE:
-                print "Adding rpath " + ':'.join(rpath_val) + " for " + obj
-            lib_rpath.extend(rpath_val)
+            for rpath_elem in rpath_val:
+                if not rpath_elem in lib_rpath:
+                    if debuglevel >= DEBUG_VERBOSE:
+                        print "Adding rpath " + rpath_elem + " for " + obj
+                    lib_rpath.append(rpath_elem)
         else:
             print "warning: " + obj + " may need rpath, but --root not specified"
 

Attachment: pgp9QaqWkQbNo.pgp
Description: PGP signature


Reply to: