Bug#326412: marked as done (discover1: Discover initscript requires /var/lib, which may not be mounted)
Your message dated Sat, 01 Oct 2005 13:32:18 -0700
with message-id <E1ELo1q-0008HQ-00@spohr.debian.org>
and subject line Bug#326412: fixed in discover1 1.7.14
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 3 Sep 2005 00:47:07 +0000
>From nick@leverton.org Fri Sep 02 17:47:07 2005
Return-path: <nick@leverton.org>
Received: from tauism.org [217.155.219.14]
by spohr.debian.org with smtp (Exim 3.36 1 (Debian))
id 1EBMBV-0002yX-00; Fri, 02 Sep 2005 17:47:06 -0700
Received: (qmail 11178 invoked from network); 3 Sep 2005 00:46:30 -0000
Received: from unknown (HELO localhost) (127.0.0.1)
by localhost with SMTP; 3 Sep 2005 00:46:30 -0000
Received: from localhost.localdomain ([192.168.1.1])
by localhost (hub [192.168.1.254]) (amavisd-new, port 10024)
with ESMTP id 08980-04; Sat, 3 Sep 2005 01:46:20 +0100 (BST)
Received: from localhost (HELO warren.leverton.org) (127.0.0.1)
by leverton.org (qpsmtpd/0.28) with ESMTP; Sat, 03 Sep 2005 01:46:20 +0100
Content-Type: multipart/mixed; boundary="===============1270732928=="
MIME-Version: 1.0
From: Nick Leverton <nick@leverton.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: discover1: Discover initscript requires /var/lib, which may not be mounted
X-Mailer: reportbug 3.8
Date: Sat, 03 Sep 2005 01:46:19 +0100
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at tauism.org
Message-Id: <E1EBMBV-0002yX-00@spohr.debian.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
This is a multi-part MIME message sent by reportbug.
--===============1270732928==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: discover1
Version: 1.7.12
Severity: normal
Tags: patch
Many thanks for the quick fix to #316808. This is a similar problem
which I didn't spot at the time. The init script uses /var/lib/discover
for a working file. /var may not be mounted at the first run of
discover, either.
This isn't as serious as #316808 as discover still runs and a
problematic module can be blacklisted manually.
I'll attach a patch which, however, you probably won't want to use,
because it assumes you can write into /lib - probably a wrong assumption.
Should it be /tmp ?
Nick
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (2, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.11-1-k7
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)
Versions of packages discover1 depends on:
ii discover1-data 1.2005.07.31 hardware lists for libdiscover1
ii libc6 2.3.2.ds1-22 GNU C Library: Shared libraries an
ii libdiscover1 1.7.12 hardware identification library
-- debconf information:
* discover/manage_cdrom_devices: true
* discover/cdrom_base_mountpoint: /media/
discover/cdrom_base_mountpoint_error:
--===============1270732928==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="discover1-var-lib.diff"
--- /home/leveret/backports/discover1-1.7.13/discover/discover.init.orig 2005-07-10 17:20:38.000000000 +0100
+++ /home/leveret/backports/discover1-1.7.13/discover/discover.init 2005-09-03 01:38:06.000000000 +0100
@@ -13,6 +13,9 @@
# file that controls this init script's management of device symlinks
INITFILE=/etc/default/discover
+# module we're loading, if it crashes then we know the culprit and can skip it
+CRASHFILE=/lib/discover/crash
+
# cache, used more than once
KVERS=$(uname -r)
@@ -48,12 +51,12 @@
echo "$result"
}
-if [ -f /var/lib/discover/crash ]
+if [ -f $CRASHFILE ]
then
# The system crashed trying to load a module during the last boot
# cycle, so add an appropriate "skip" line to the skip file:
- echo "skip $(</var/lib/discover/crash)" >> $SKIPFILE
- rm -f /var/lib/discover/crash
+ echo "skip $(<$CRASHFILE)" >> $SKIPFILE
+ rm -f $CRASHFILE
sync
fi
@@ -206,11 +209,11 @@
log_success_msg "Loading $MODULE module..."
fi
- # Note the module being loaded in /var/lib/discover/crash. If loading
+ # Note the module being loaded in $CRASHFILE. If loading
# the module crashes the machine, this file will exist at the next
# boot, and we'll add an appropriate "skip" line to the conffile so we
# don't try to load it again.
- echo $MODULE > /var/lib/discover/crash
+ echo $MODULE > $CRASHFILE
sync
# '|| true' make sure we start up, even if one module fails to load.
@@ -218,7 +221,7 @@
# The module loaded without incident, so we can safely remove the crash
# file.
- rm -f /var/lib/discover/crash
+ rm -f $CRASHFILE
sync
done
--===============1270732928==--
---------------------------------------
Received: (at 326412-close) by bugs.debian.org; 1 Oct 2005 20:39:22 +0000
>From katie@spohr.debian.org Sat Oct 01 13:39:22 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1ELo1q-0008HQ-00; Sat, 01 Oct 2005 13:32:18 -0700
From: Gaudenz Steinlin <gaudenz@debian.org>
To: 326412-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#326412: fixed in discover1 1.7.14
Message-Id: <E1ELo1q-0008HQ-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Sat, 01 Oct 2005 13:32:18 -0700
Delivered-To: 326412-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2
Source: discover1
Source-Version: 1.7.14
We believe that the bug you reported is fixed in the latest version of
discover1, which is due to be installed in the Debian FTP archive:
discover1-udeb_1.7.14_powerpc.udeb
to pool/main/d/discover1/discover1-udeb_1.7.14_powerpc.udeb
discover1_1.7.14.dsc
to pool/main/d/discover1/discover1_1.7.14.dsc
discover1_1.7.14.tar.gz
to pool/main/d/discover1/discover1_1.7.14.tar.gz
discover1_1.7.14_powerpc.deb
to pool/main/d/discover1/discover1_1.7.14_powerpc.deb
libdiscover1-dev_1.7.14_powerpc.deb
to pool/main/d/discover1/libdiscover1-dev_1.7.14_powerpc.deb
libdiscover1-pic_1.7.14_powerpc.deb
to pool/main/d/discover1/libdiscover1-pic_1.7.14_powerpc.deb
libdiscover1_1.7.14_powerpc.deb
to pool/main/d/discover1/libdiscover1_1.7.14_powerpc.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 326412@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gaudenz Steinlin <gaudenz@debian.org> (supplier of updated discover1 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 25 Sep 2005 14:57:16 +0200
Source: discover1
Binary: libdiscover1 discover1 libdiscover1-pic discover1-udeb libdiscover1-dev
Architecture: source powerpc
Version: 1.7.14
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Gaudenz Steinlin <gaudenz@debian.org>
Description:
discover1 - hardware identification system
discover1-udeb - hardware identification library (udeb) (udeb)
libdiscover1 - hardware identification library
libdiscover1-dev - hardware identification library development files
libdiscover1-pic - hardware identification library - static PIC version
Closes: 307164 326412
Changes:
discover1 (1.7.14) unstable; urgency=low
.
* add support for arch specific device lists
* remove unused prototypes form lib/utils.h
* update adress of FSF in copyright
* remove old comments in lib/utils.h. They are
no longer needed and confuse translators. (closes: #307164)
* applied patch from Nick Leverton to write the
crashfile in /lib/discover. (closes: #326412)
Files:
ed4a83ce293fc4570781db548b174c43 798 admin optional discover1_1.7.14.dsc
d0de9c6b968724ed2d0e6c69971a616b 607825 admin optional discover1_1.7.14.tar.gz
cb99eb2d2189a9a65411ca23547af9b4 69896 admin optional discover1_1.7.14_powerpc.deb
05d17e8244b18ce68f2673c1598ffcb3 100378 libs optional libdiscover1_1.7.14_powerpc.deb
12aa884a44fdbd83b3076178c07f7ddf 24934 libdevel optional libdiscover1-dev_1.7.14_powerpc.deb
661e9198c5b17607383dcfa426d3d957 57152 libs extra libdiscover1-pic_1.7.14_powerpc.deb
31d12c3efd3ad5aef70e79fd89ddcddf 39562 debian-installer extra discover1-udeb_1.7.14_powerpc.udeb
Package-Type: udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDPtn58rUqXQpftocRAs1gAKCIb7Svi2SdV/pLGv0HqoeaVIEihwCgr1cP
K1qsKlDiJCBudr/vtMxDYGo=
=3Vys
-----END PGP SIGNATURE-----
Reply to: