[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#226057: one approach



For the record, I tried fixing this using the attached patch. It doesn't
work very well because 

a) the modules.conf gets gummed up with all these ugly and useless
   parameters to all modules
b) ide-core is not explicitly modprobed anyway, it's pulled in by deps,
   so AFAIK it never sees the options anyway

At the moment, explicitly modprobing ide-core and adding a hack to grep
out the ide= options for it seems to be the only way to fix this. Ugh.

-- 
see shy jo
diff -ur --exclude=.svn hw-detect/TODO hw-detect.foo/TODO
--- hw-detect/TODO	2005-06-19 19:18:26.000000000 -0400
+++ hw-detect.foo/TODO	2005-06-19 14:55:26.000000000 -0400
@@ -14,3 +14,8 @@
   can include nice descriptions of disk devices. Note that discover's
   descriptions of modules are an alternate source of info, which uses
   different names too. This could stand to be unified.
+
+* hw-detect passes user-params to modprobe to allow users to enter module
+  params at the kernel boot line. If this works out well, we should extend
+  it to other modprobe calls for consistency, including others in
+  hw-detect, and disk-detect, ethdetect, and elsewhere in d-i.
diff -ur --exclude=.svn hw-detect/debian/changelog hw-detect.foo/debian/changelog
--- hw-detect/debian/changelog	2005-06-19 19:18:15.000000000 -0400
+++ hw-detect.foo/debian/changelog	2005-06-19 19:16:05.000000000 -0400
@@ -5,6 +5,14 @@
     useful for debugging. Missing modules are still logged, and d-i already 
     handles helping the user with important undeteted hardware (ethernet,
     cdrom, disk).
+  * Pass boot parameters to the hw-detect modprobe call if there are no other
+    params. Relies on the kernel not doing things too differently in parameter
+    parsing in modulear and non-modular code, and not blowing up when a
+    module gets an unknown option. This seems to be the case, but time
+    will tell. In an ideal world it could use modinfo to separate the
+    supported parameters, but that info is incomplete.
+  * This makes ide=nodma work as expected by monolithic kernel users, amoung
+    other things. Closes: #226057.
 
  -- Joey Hess <joeyh@debian.org>  Sun, 19 Jun 2005 13:52:02 -0400
 
diff -ur --exclude=.svn hw-detect/hw-detect.sh hw-detect.foo/hw-detect.sh
--- hw-detect/hw-detect.sh	2005-06-19 19:18:49.000000000 -0400
+++ hw-detect.foo/hw-detect.sh	2005-06-19 18:59:01.000000000 -0400
@@ -14,6 +14,7 @@
 "
 MISSING_MODULES_LIST=""
 SUBARCH="$(archdetect)"
+BOOT_PARAMS=$(echo $(user-params))
 
 prebaseconfig=/usr/lib/prebaseconfig.d/30hw-detect
 
@@ -75,7 +76,7 @@
 	local devs=""
 	local olddevs=""
 	local newdev=""
-	local params=""
+	local params="$BOOT_PARAMS"
     
 	if [ "$PROMPT_MODULE_PARAMS" = 1 ]; then
 		db_register hw-detect/module_params hw-detect/module_params/$module

Attachment: signature.asc
Description: Digital signature


Reply to: