I've taken a look at your new code now, so I can give a more reasoned reaction. Note: this still needs other ppl to look at. The current sequence of actions by grub-installer is: 0. Update mtab in chroot to properly reflect mounted partitions 1. Install grub package 2. Run d-i's os-prober component to locate other OS's for multi-boot configuration 3. Ask where grub should be installed (default is MBR of first disk) 4. Run grub-install 5. Run update-grub to create initial menu.lst 6. Add any user parameters in menu.lst and re-run update-grub 7. Append extra menu items for other operating systems With your new code I think this would change to: 0-4: probably unchanged? 5. Set user parameters in /etc/grub.conf 6. Drop file(s) with menu items for other OS's in /etc/grub/post.d/ 7. Run update-grub On Thursday 03 February 2005 07:26, Jason Thomas wrote: > On Tue, Feb 01, 2005 at 11:24:26PM +0100, Frans Pop wrote: > > > The rewrite does not include any device detection code. The idea > > > was to put that into the postinst. Hmmm. We are talking about the kernel root (device that has /boot), right? For that I think the postinst should be OK. What about the groot? Would that still have to be passed to grub-install? Are you planning changes to grub-install as well? > > That means that device detection would take place _before_ > > update-grub is run, correct? > > Where would the results of the device detection be stored? > > How would device detection be triggered again if there are hardware > > changes (or even if the user decides to use udev or something like > > that)? > > the new update-grub would read it's device information from > /etc/grub/kernel.conf Right. > But I didn't really think about triggering a redetection. perhaps > dpkg-reconfigure grub. I feel this will need some consideration. Like trying to identify cases where redetection would be needed, if automatic redetection would be useful and where any checks for a changed configuration should be implemented (maybe there should be some sanity checks in update-grub suggesting to run dpkg-reconfigure if they fail). > I was thinking that when the grub package was installed it would do > some auto detection and then allow the user to modify the results. That > way people with corner cases (such as raid) are covered. Hmmm. One of the design goals of d-i is to reduce the number of questions as much as possible. For d-i, we would at least have to be able to run the postinst of grub non-interactive. It would be nice if auto-detection were as complete as possible and if situations that can not be auto-detected would be signalled in some way (and not fall back to some default like now), so we would be able to ask the questions from within d-i only if needed. Cheers, Frans Pop
Attachment:
pgpTAGzv_7A4C.pgp
Description: PGP signature