[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#291362: installation-reports: LVM install failed due to missing dmsetup

On Thu, Jan 20, 2005 at 02:59:00PM -0500, Joey Hess wrote:
> initrd-tools 0.1.76 changed to abort on install to LVM if dmsetup was
> not installed. I think this was a mistake. I'm ccing tbm, who made the
> change.

I made the change.

> This was apparently added as part of a patch to support encrypted root
> filesystems, which is not supported by d-i at all; silently adding a
> requirement that dmsetup be installed for lvm systems when previously it
> was not needed is not a good thing to have done.

Why is the d-i seeing the new initrd-tools at all?
I thought base was frozen?

> It seems to me that the above code could easily be rewritten to skip
> calling dmsetup if it was not installed, and run the lvm function. This
> might be a little less robust on systems that do use encrypted root
> filesystems, but at least it wouldn't require us to make last-minute changes
> to d-i and debian-cd to add dmsetup everywhere.

At any rate, I agree with your solution, if there is no dmsetup it makes
sense to fall back to using lvm. Since cryptsetup depends on dmsetup, there
is nothing wrong with this solution.

Wesley W. Terpstra

Reply to: