[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#224641: Testing and new patch!



On Sat, Nov 27, 2004 at 09:38:51AM +0000, Alex Owen wrote:
> OK  I have tested grub-installer-1.07-postinst.patch2 bt it did not
> work...

> Here is grub-installer-1.07-postinst.patch3 which is untested but I
> believe fixes the remaining problems.

> If I get to test it I'll post again!


> @@ -390,6 +409,22 @@
>  	update_grub # again, to add new options to all the Debian kernel entries
>  fi
>  
> +if [ -n "$serial" ] ; then
> +	#if this is a serial console ensure #kopts is correct...
> +	#despite posn of "console=" relative to "--" in /proc/cmdline
> +	if echo "$user_params" | grep -q console=ttyS; then
> +	    # Modify menu.lst to include serial console.
> +	    sed "s!^\(# kopt=.*\)!\1 $user_params!" \
> +		< /target/boot/grub/menu.lst > /target/boot/grub/menu.lst.new
> +	    mv /target/boot/grub/menu.lst.new /target/boot/grub/menu.lst
> +	    update_grub # again, to add new options to all the Debian kernel entries
> +	fi
> +	# Modify menu.lst so _grub_ uses serial console.
> +	grub_serial_console $serial | cat - /target/boot/grub/menu.lst > /target/boot/grub/menu.lst.new
> +	mv /target/boot/grub/menu.lst.new /target/boot/grub/menu.lst
> +fi 
> +
> +
>  # Generation menu.lst addition for other OSes.
>  tmpfile=/tmp/menu.lst.extras
>  OLDIFS="$IFS"

Perhaps it would be better to push this logic into the user-params command
instead, so that other archs can take advantage of it as well?

Thanks,
-- 
Steve Langasek
postmodern programmer

Attachment: signature.asc
Description: Digital signature


Reply to: