As bast I can tell, the patch in this bug does not change the behavior of rootskel. I cannot apply patches without an explanation of the bug that the patch fixes, and there is no explaination of why the changes in this patch are useful. The patch makes TERM_FRAMEBUFFER not be set if it is already set. But the only thing in all of rootskel that sets TERM_FRAMEBUFFER is the code here, so this is a no-op. The patch adds a check for debian-installer/framebuffer=true and does not set TERM_FRAMEBUFFER if it's not. But this duplicates the check made in S40framebuffer-module-linux-*. If debian-installer/framebuffer=false, then S40framebuffer-module-linux-* will not load framebuffer modules, and so /dev/fb/0 will not exist, and so the existing check in S35framebuffer-linux should suffice. Posting a proper explanation would have been a much better way to get this fixed than posting an unexplained patch. At this point all I know is that debian-installer/framebuffer=false works on i386, and may not elsewhere, but I can't tell why not. It could even still be user error; this string is known to be hard to type correctly on eg, French keyboards. -- see shy jo
Attachment:
signature.asc
Description: Digital signature