[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#260227: patch



Nikolai Prokoschenko wrote:
> On Mon, Sep 13, 2004 at 06:07:15PM +0300, Eugeniy Meshcheryakov wrote:
> > > If it's fine for Ukrainian, it should be good enough for Russian.
> > > Committing patch. Hope it works, I'm not a console user... :(
> > If so you should also remove code that installs console-cyrillic and
> > console-terminus from languagechooser and make termwrap use ruscii_8x16
> > font instead unavailable console-cyrillic.
> 
> Done. I'm committing the changes to languagechooser and base-config right
> now, could someone please check that they don't break stuff? 

By committing changes of this sort to base-config and languagechooser at
this point *without testing them*, you run the risk of getting a nice
errata item for your language for the final sarge release that says
"does not work, pick another language". It's stupid, don't do it.

Also, NEVER commit code changes to base-config at this point without
talking to me. I have to explain each code change in base-config to the
release managers; which is impossible if nobody has explained them to
me. People who abuse this privelige will lose commit access to
base-config.

(BTW, the branch of base-config you committed your changes to is not one
that will ever be released in sarge, so I assume you just broke your
language by getting languagechooser and base-config out of sync. One
reason you should talk to the maintainer first.)

(Also BTW, you documented your change in the changelog entry for a
released version of base-config, which is broken and indicates you don't
know what you're doing even if none of the above did.)

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: