[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#255940: marked as done (elilo_installer fails on sarge)



Your message dated Sun, 27 Jun 2004 16:02:05 -0400
with message-id <E1Befqn-0003tP-00@newraff.debian.org>
and subject line Bug#255940: fixed in elilo-installer 0.0.5
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 23 Jun 2004 22:00:16 +0000
>From lieb@wildopensource.com Wed Jun 23 15:00:16 2004
Return-path: <lieb@wildopensource.com>
Received: from ottawa.wildopensource.com [192.139.46.141] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BdFmy-00023y-00; Wed, 23 Jun 2004 15:00:16 -0700
Received: from dh3.suntan.fremont.ca.us (adsl-67-117-70-170.dsl.sntc01.pacbell.net [67.117.70.170])
	(using SSLv3 with cipher RC4-MD5 (128/128 bits))
	(No client certificate requested)
	by ottawa.wildopensource.com (Postfix) with ESMTP
	id AFE6FAFAF7; Wed, 23 Jun 2004 18:00:13 -0400 (EDT)
From: Jim Lieb <lieb@wildopensource.com>
Organization: Wild Open Source Inc.
To: submit@bugs.debian.org
Subject: elilo_installer fails on sarge
Date: Wed, 23 Jun 2004 15:00:02 -0700
User-Agent: KMail/1.5
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_i1f2AObj6bA8GI/"
Message-Id: <200406231500.02875.lieb@wildopensource.com>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


--Boundary-00=_i1f2AObj6bA8GI/
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


Package: elilo_installer
Version: 0.0.5
Processor: ia64
Machine: HP rx2600 server

The postinst script fails leaving the installation unbootable.
This affects both netinst and bizcard installs.
In addition, the efi bootable partition discovery and selection
does not find a valid partition.

Patch set follows in attachment.  This patch fixes the following:

1. The script runs without sh scripting errors.

2. Correctly finds and displays all partition candidates.

3. the title is correctly displayed.

4. the "no partition found" error message in the template
  now recommends a partition size.

5. Removes dependency on executables in /target filesystem.

Note:
  this install script depends on 2.4 devfs which will be deprecated
in 2.6.
-- 
*************
Jim Lieb			Wild Open Source Inc.
lieb@wildopensource.com		Cell: 831.295.9317
Office: 831.421.0883            Fax:  831.421.0885

--Boundary-00=_i1f2AObj6bA8GI/
Content-Type: text/x-diff;
  charset="us-ascii";
  name="elilo_installer.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="elilo_installer.patch"

Index: elilo-installer.postinst
===================================================================
--- elilo-installer.postinst	(revision 16905)
+++ elilo-installer.postinst	(working copy)
@@ -1,6 +1,8 @@
 #!/bin/sh
 set -e
 
+. /usr/share/debconf/confmodule
+
 if [ -f /etc/mtab ]; then
     MTAB=/etc/mtab
 else
@@ -8,34 +10,48 @@
 fi
 
 # detect which is the root partition: /target
-rootfs=`/target/bin/sed -ne '/^[^ ]* \/target /s/ .*//p' $MTAB`
+rootfs=`grep ' /target ' $MTAB |cut -d' ' -f1 -s`
 
 # Find all partitions with fat filesystems and the boot flag set.  May be
 # enough just to look for one of those.  OTOH, elilo will convert any
 # partition you give it to FAT...  Also translates /dev/discs paths in to
 # real /dev/scsi (or ide) paths.
 
-p=$(for i in /dev/discs/*/disc; do
-	dev=$(parted $i print | sed -n "s|^Disk geometry for \([^:]*\)/disc:.*$|\1|p")
-	parted $i print | sed -n "s|^\([0-9]\+\) \+[0-9\.]\+ \+[0-9\.]\+ \+fat[0-9]* \+boot$|$dev/part\1|p"
-     done)
+rm -f /tmp/efi_boot.list
 
-if [ "$p" = '' ]; then
+for d in /dev/discs/*/disc; do
+    parted $d print | ( while read minor start end fs nameflags ; do
+      case "$minor" in
+      Disk)
+	if [ "$start" = geometry ]; then
+	    dev=$(echo $fs | sed -n "s|\([^:]*\)/disc:|\1|p")
+	fi
+	;;
+      [1-9])
+	case "$fs" in
+	fat16|fat32)
+	    if echo "$nameflags" | grep "boot" >/dev/null; then
+		echo ${dev}/part${minor} >> /tmp/efi_boot.list
+	    fi
+	    ;;
+	esac
+	;;
+      esac
+    done)
+done	
+if [ -s /tmp/efi_boot.list ]; then
+    for d in `cat /tmp/efi_boot.list`; do
+	if [ -n "$BOOTPARTS" ]; then
+	    BOOTPARTS="$BOOTPARTS, $d"
+	else
+	    BOOTPARTS=$d
+	fi
+    done
+else
 	db_input critical elilo-installer/no-bootpart
 	db_go
 	exit 1
 fi
-
-for i in $p; do
-	if [ $BOOTPARTS ]; then
-		BOOTPARTS="$BOOTPARTS, $i"
-	else
-		BOOTPARTS=$i
-	fi
-done
-
-. /usr/share/debconf/confmodule
-
 db_subst elilo-installer/bootpart BOOTPARTS $BOOTPARTS
 
 db_fset elilo-installer/bootpart seen false
Index: elilo-installer.templates
===================================================================
--- elilo-installer.templates	(revision 16905)
+++ elilo-installer.templates	(working copy)
@@ -9,4 +9,9 @@
 Type: error
 _Description: No boot partitions detected
  There were no suitable partitions found for elilo to use.  Elilo needs
- a partition with a FAT filesystem, and the boot flag set.
+ a partition of 50-100MB with a FAT filesystem, and the boot flag set.
+
+Template: debian-installer/elilo-installer/title
+Type: text
+#  Main menu item
+_Description: Install the elilo boot loader on a hard disk

--Boundary-00=_i1f2AObj6bA8GI/--


---------------------------------------
Received: (at 255940-close) by bugs.debian.org; 27 Jun 2004 20:08:15 +0000
>From katie@ftp-master.debian.org Sun Jun 27 13:08:15 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Befwl-000653-00; Sun, 27 Jun 2004 13:08:15 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1Befqn-0003tP-00; Sun, 27 Jun 2004 16:02:05 -0400
From: dann frazier <dannf@debian.org>
To: 255940-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#255940: fixed in elilo-installer 0.0.5
Message-Id: <E1Befqn-0003tP-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 27 Jun 2004 16:02:05 -0400
Delivered-To: 255940-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Source: elilo-installer
Source-Version: 0.0.5

We believe that the bug you reported is fixed in the latest version of
elilo-installer, which is due to be installed in the Debian FTP archive:

elilo-installer_0.0.5.dsc
  to pool/main/e/elilo-installer/elilo-installer_0.0.5.dsc
elilo-installer_0.0.5.tar.gz
  to pool/main/e/elilo-installer/elilo-installer_0.0.5.tar.gz
elilo-installer_0.0.5_ia64.udeb
  to pool/main/e/elilo-installer/elilo-installer_0.0.5_ia64.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 255940@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
dann frazier <dannf@debian.org> (supplier of updated elilo-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 27 Jun 2004 13:34:42 -0600
Source: elilo-installer
Binary: elilo-installer
Architecture: source ia64
Version: 0.0.5
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: dann frazier <dannf@debian.org>
Description: 
 elilo-installer - Install elilo on a hard disk (udeb)
Closes: 255940
Changes: 
 elilo-installer (0.0.5) unstable; urgency=low
 .
   * Colin Watson
     - Depend on parted-udeb.
   * Jim Lieb
     - The script runs without sh scripting errors.
     - Correctly finds and displays all partition candidates.
     - the title is correctly displayed.
     - the "no partition found" error message in the template
     - Removes dependency on executables in /target filesystem.
     - Closes: #255940
Files: 
 5a004f0a67c1ce330b05602fbf5c3796 605 debian-installer standard elilo-installer_0.0.5.dsc
 fb7aa328f5d9b115b865941a63686f18 17672 debian-installer standard elilo-installer_0.0.5.tar.gz
 22bf023e50a8dfe467faa0da921224c6 9314 debian-installer standard elilo-installer_0.0.5_ia64.udeb
package-type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA3yUEhuANDBmkLRkRAgBoAJ9nT6YW9YtJASj+EbNN/tW9hXqF1gCfTX1R
L5QFMJLdgCgcWRFBwvV+qFs=
=Wb03
-----END PGP SIGNATURE-----



Reply to: