[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#255128: cdrom-detect: Bad handling of mount error



Osamu Aoki wrote:
> Are you thinking like:

Yes, something like that..

> +            log "$(echo "Unmounting CD..." ; umount /cdrom 2>&1 || true)"
> +                log "$(echo "Unmounting CD..." ; umount /cdrom 2>&1 || true)"
> +            log "$(echo "Unmounting CD..." ; umount /cdrom 2>&1 || true)"

I'd say this is unnecessaty, stderr is already intercepted.

> I was not sure I can add "| logger"  after "if mount ..." either.

You can't, it will lose the exit status. Luckily all stderr is sent to
/var/log/messages anyway.

> Also, I wish I could add a screen display stating "Trying again".
> Otherwise, it takes forever especially with 1 second pause as Vince
> complained.  I never used debconf.

Let's get it working, and then later make it pretty. That's not hard
to do, and I'm sure someone will eventally add a progress bar for it.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: